Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] New command percli dac build #1699

Merged
merged 10 commits into from
Jan 19, 2024
Merged

[FEATURE] New command percli dac build #1699

merged 10 commits into from
Jan 19, 2024

Conversation

AntoineThebaud
Copy link
Contributor

@AntoineThebaud AntoineThebaud commented Jan 12, 2024 •
edited

Description

New command percli dac build to build (a) dashboard(s) from (a) DaC file(s).

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

@AntoineThebaud AntoineThebaud force-pushed the antoinethebaud/DaC-build-command branch 6 times, most recently from 148b73d to 8bbf272 Compare January 15, 2024 19:05
@AntoineThebaud AntoineThebaud marked this pull request as ready for review January 16, 2024 21:21
@AntoineThebaud
Copy link
Contributor Author

@Nexucis this one is also ready for review, I'm just going to change the target branch to feat/dashboard-as-code once #1695 is merged.

Base automatically changed from antoinethebaud/DaC-part2 to feat/dashboard-as-code January 17, 2024 10:01
Nexucis
Nexucis approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !!

@Nexucis Nexucis mentioned this pull request Jan 18, 2024
Merged
@AntoineThebaud
New command percli dac build to build a dashboard from a DaC CUE de…
752823d 
…finition

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud
Update user doc
0103ada 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud
Add unit tests
2c21eb3 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud
Sanitize the file input
f49b263 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud
Fix formatting
22afad8 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud
fix unit tests + bump cue version to 0.7.0 for all gh actions
834b3bd 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud
Add mode flag to choose between output on stdout vs file
4998bc3 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud
Properly support -d flag to build multiple DaC files at once
dfe1db2 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud
Add an explanation about a non-intuitive difference between `percli d…
802e216 
…ac build` and `cue eval`

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud
Adjustments following PR review
447e6ae 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud AntoineThebaud merged commit 6c6f21a into feat/dashboard-as-code Jan 19, 2024
19 checks passed
@AntoineThebaud AntoineThebaud deleted the antoinethebaud/DaC-build-command branch January 19, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nexucis Nexucis Nexucis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AntoineThebaud @Nexucis