Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fixing external ListVariable overriding dashboard ListVariable in query param #1996

Merged
merged 2 commits into from
May 16, 2024

Conversation

Gladorme
Copy link
Member

@Gladorme Gladorme commented May 16, 2024

Description

Doing a quick fix for issue #1954, I think there's still room for improvements. Lot of useEffects to remove in TemplateVariable.tsx + we should have a method returning all variables def a dashboard can use and remove variables definitions overrode. I will check when I have time 😄

fixes #1954

Screenshots

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky.
    See Storybook
    and e2e docs for more details. Common issues
    include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@Gladorme Gladorme force-pushed the gladorme/fix-externalvar-overriding branch from aa3bee9 to 0be36d2 Compare May 16, 2024 14:14
…e in query param

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
@Gladorme Gladorme force-pushed the gladorme/fix-externalvar-overriding branch from 0be36d2 to ab7f1d3 Compare May 16, 2024 14:15
Copy link
Member

@celian-garcia celian-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm interested on that fix, can we call each other in 30min ?

@Gladorme Gladorme force-pushed the gladorme/fix-externalvar-overriding branch from 58469b6 to 84660f6 Compare May 16, 2024 15:06
@Gladorme Gladorme force-pushed the gladorme/fix-externalvar-overriding branch from 84660f6 to 5ffd07d Compare May 16, 2024 15:08
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
@Gladorme Gladorme force-pushed the gladorme/fix-externalvar-overriding branch from 5ffd07d to ec8ee26 Compare May 16, 2024 15:09
@Gladorme Gladorme added this pull request to the merge queue May 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2024
@Nexucis Nexucis added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 7e6dc64 May 16, 2024
19 checks passed
@Nexucis Nexucis deleted the gladorme/fix-externalvar-overriding branch May 16, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overriden external ListVariable still takes precedence as query param
3 participants