Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use own build script for gtest #485

Merged
merged 13 commits into from Jan 24, 2019
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -79,6 +79,7 @@
* Updated gtest version to 1.8.1: [#478](https://github.com/personalrobotics/aikido/pull/478)
* Added DART 6.7 support: [#480](https://github.com/personalrobotics/aikido/pull/480)
* Fixed use of dart::common::make_unique for C++14 enabled compilers: [#481](https://github.com/personalrobotics/aikido/pull/481)
* Changed to use own build script for GoogleTest: [#485](https://github.com/personalrobotics/aikido/pull/485)

### 0.2.0 (2018-01-09)

Expand Down
15 changes: 0 additions & 15 deletions CMakeLists.txt
Expand Up @@ -101,21 +101,6 @@ macro(aikido_check_package variable component dependency)
endif()
endmacro()

#==============================================================================
# Register an Aikido test.
#
set_property(GLOBAL PROPERTY AIKIDO_TESTS)

function(aikido_add_test target_name)
add_executable("${target_name}" ${ARGN})
add_test("${target_name}" "${target_name}")

target_link_libraries("${target_name}" gtest gtest_main)

set_property(GLOBAL APPEND PROPERTY AIKIDO_TESTS "${target_name}")
format_add_sources(${ARGN})
endfunction()

#==============================================================================
# Required Dependencies
#
Expand Down
25 changes: 23 additions & 2 deletions tests/CMakeLists.txt
@@ -1,5 +1,26 @@
# GTest setup.
add_subdirectory(gtest)
# GTest setup
add_library(gtest STATIC "${CMAKE_CURRENT_SOURCE_DIR}/gtest/src/gtest-all.cc")
target_include_directories(gtest SYSTEM BEFORE
PUBLIC "${CMAKE_CURRENT_SOURCE_DIR}/gtest/include"
PRIVATE "${CMAKE_CURRENT_SOURCE_DIR}/gtest"
)
if(NOT WIN32)
target_link_libraries(gtest PUBLIC pthread)
endif()
add_library(gtest_main STATIC gtest/src/gtest_main.cc)
target_link_libraries(gtest_main PUBLIC gtest)

# Define aikido_add_test for registering Aikido tests.
set_property(GLOBAL PROPERTY AIKIDO_TESTS)
function(aikido_add_test target_name)
add_executable("${target_name}" ${ARGN})
add_test("${target_name}" "${target_name}")

target_link_libraries("${target_name}" gtest gtest_main)

set_property(GLOBAL APPEND PROPERTY AIKIDO_TESTS "${target_name}")
format_add_sources(${ARGN})
endfunction()

# Add helper scripts to the include path.
include_directories("${CMAKE_CURRENT_SOURCE_DIR}")
Expand Down
2 changes: 1 addition & 1 deletion tests/gtest/CMakeLists.txt
Expand Up @@ -108,7 +108,7 @@ endif()
set(gtest_build_include_dirs
"${gtest_SOURCE_DIR}/include"
"${gtest_SOURCE_DIR}")
include_directories(SYSTEM ${gtest_build_include_dirs})
include_directories(${gtest_build_include_dirs})

# Summary of tuple support for Microsoft Visual Studio:
# Compiler version(MS) version(cmake) Support
Expand Down