Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mico, MicoRobot, and MicoHand contain meaningless OWD-specific code #93

Closed
mkoval opened this issue Apr 5, 2015 · 1 comment
Closed
Assignees

Comments

@mkoval
Copy link
Member

mkoval commented Apr 5, 2015

It looks like Mico, MicoRobot, and MicoHand were directly copied-and-pasted from HERB with, in many cases, no modification. There are a lot of HERB and OWD-specific vestiges in these files that don't make any sense on ADA.

For example...

  • MicoHand has:
    • `spread
    • ResetHand()
    • GetState()
  • MicoRobot has:
    • ExecuteTrajectory() has logic to deal with multiple manipulators and a mobile base
    • a bunch of HERB-specific code commented out
  • Mico has:
    • Servo(), as implemented for OWD (is this the same on the MICO?)
    • GetTrajectoryStatus()
    • ClearTrajectoryStatus()
    • SetVelocityLimits()
@mkoval mkoval added the bug label Apr 5, 2015
This was referenced Apr 5, 2015
@mkoval
Copy link
Member Author

mkoval commented Apr 25, 2015

Fixed in #97.

@mkoval mkoval closed this as completed Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants