[APT-1257] documentation for hourly absence creation new endpoint #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmad-tayel
force-pushed
the
master
branch
2 times, most recently
from
5a954a0
to
f6ed71e
Compare
ahmad-tayel
force-pushed
the
master
branch
2 times, most recently
from
8001f0f
to
6aeaea5
Compare
|
That was a problem in the documentation itself, this endpoint is
always sending 200 but it was written here 201 which is wrong, I believe
the API users are already mitigating this by checking if the response is
200 or 201
…On Tue, Feb 21, 2023 at 11:38 PM Dino Pehratovic ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In personio-personnel-data-api-oa3.yaml
<#141 (comment)>:
> @@ -1749,7 +1749,7 @@ paths:
- language: "php"
code: "Auto-generated code snippets for this language may not be supported"
responses:
- "201":
+ "200":
[Question]: Is this change willingly happening? Why are we changing the
response code from 201 to 200 for a create endpoint?
—
Reply to this email directly, view it on GitHub
<#141 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A55F7BKAMUPUD26ONNOZEO3WYU7UZANCNFSM6AAAAAAU6HXWXY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
[image: Ahmed Tayel]
Ahmed Tayel
Junior Backend Engineer
M: +39 3792088835
E: ***@***.*** ***@***.***>
[image: Personio Logo]
Personio. The People Operating System.
www.personio.de
Personio GmbH & Co. KG
Billing Address: Rundfunkplatz 4, 80335 Munich
Visitor and Mailing Address: Seidlstraße 3, 80335 Munich (VAT DE351718597)
Commercial Register: HRA 115934, Local Court Munich | Personally liable
shareholder: Personio Group GmbH,
Managing director: Hanno Renner, Commercial Register: HRB 213189, Local
Court Munich, Germany
We are hiring <https://www.personio.de/ueber-uns/jobs/>
Help us build the The People Operating System,
or refer a friend who would.
--
*Personio SE & Co. KG
Seidlstraße 3, 80335 Munich
Germany*
Commercial
Register: HRA 115934, Local Court Munich
VAT-ID DE351718597
General
partner: Personio Group SE; Managing Board Member: Hanno Renner; Chair of
the Supervisory Board: Roman Schumacher; Commercial Register: HRB 281581,
Local Court Munich, Germany
|
dinomite94
requested changes
Feb 23, 2023
maricn
reviewed
Feb 24, 2023
maricn
approved these changes
Feb 27, 2023
dinomite94
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.