Add minimum working implementation of the refactored browser test support #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darmen
force-pushed
the
browser-test-mvp
branch
from
4a3052d
to
8512053
Compare
darmen
requested review from
andrebq,
akhilbv,
friduchin and
arunprakashind
and removed request for
andrebq,
akhilbv,
friduchin and
arunprakashind
darmen
force-pushed
the
browser-test-mvp
branch
from
8512053
to
7228862
Compare
darmen
changed the title
arunprakashind
previously approved these changes
Oct 4, 2023
andrebq
previously approved these changes
Oct 4, 2023
darmen
force-pushed
the
browser-test-mvp
branch
from
b115188
to
fe764f3
Compare
andrebq
previously approved these changes
Oct 4, 2023
darmen
force-pushed
the
browser-test-mvp
branch
from
fe764f3
to
aa48238
Compare
arunprakashind
approved these changes
Oct 4, 2023
andrebq
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To gradually migrate Browser tests to the Builder implementation introduced in #123.
Scope
SyntheticTestBuilderSyntheticBrowserTestBuilderclass and corresponding DLS with a minimum configuration that passes the end-to-end test