Implement browsersAndDevices function for browser tests
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darmen
force-pushed
the
browser-device
branch
from
85bba4b
to
f067227
Compare
|
Please add a description to the PR |
darmen
force-pushed
the
browser-device
branch
from
f067227
to
bbe81b8
Compare
|
@azzmiks Resolved conflicts here |
darmen
force-pushed
the
browser-device
branch
2 times, most recently
from
3af5719
to
441a45c
Compare
azzmiks
previously approved these changes
Oct 16, 2023
darmen
force-pushed
the
browser-device
branch
from
441a45c
to
cc95bb4
Compare
azzmiks
approved these changes
Oct 17, 2023
friduchin
reviewed
Oct 17, 2023
src/main/kotlin/com/personio/synthetics/builder/SyntheticBrowserTestBuilder.kt
Show resolved
Hide resolved
andrebq
approved these changes
Oct 18, 2023
andrebq
approved these changes
Oct 18, 2023
andrebq
force-pushed
the
browser-device
branch
from
cc95bb4
to
8df6675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To support setting browsers and devices in synthetic browser tests.