Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the test status not set by default #144

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

darmen
Copy link
Collaborator

@darmen darmen commented Oct 20, 2023

Scope

This PR changes the status behaviour for new implementations of Multi-step API and Browser tests: the status is no longer set as paused by default.

@darmen darmen requested a review from a team as a code owner October 20, 2023 12:40
@darmen darmen force-pushed the remove-default-paused-status branch 3 times, most recently from 713dfae to f3aa6ac Compare October 20, 2023 13:01
azzmiks
azzmiks previously approved these changes Oct 20, 2023
@andrebq
Copy link
Contributor

andrebq commented Oct 23, 2023

What happens if we create a test without a status? Will it throw an exception or the test will be created in a undefined state in Datadog?

arunprakashind
arunprakashind previously approved these changes Oct 23, 2023
@arunprakashind
Copy link
Collaborator

arunprakashind commented Oct 23, 2023

What happens if we create a test without a status? Will it throw an exception or the test will be created in a undefined state in Datadog?

@andrebq If no status is provided in the test,

  1. If test doesn't exist in datadog -> The status would be "Paused" in Datadog
  2. If test exists in datadog and is "Live/Paused" -> The same status would be maintained "Live/Paused"

@andrebq
Copy link
Contributor

andrebq commented Oct 23, 2023

@andrebq If no status is provided in the test,

  1. If test doesn't exist in datadog -> The status would be "Paused" in Datadog
  2. If test exists in datadog and is "Live/Paused" -> The status would be maintained "Live/Paused"

If we want to avoid changing something from LIVE to PAUSED (I am assuming this is the reason for not having it set to PAUSED by default), it might be better to throw an exception instead of assuming Datadog will set it to Paused.

Although, I wonder if it makes sense to always revert to PAUSED, given we are potentially changing the test every time this automation runs.

What do you think?

@darmen darmen dismissed stale reviews from arunprakashind and azzmiks via 65e1a06 October 23, 2023 08:16
@darmen darmen force-pushed the remove-default-paused-status branch from f3aa6ac to 65e1a06 Compare October 23, 2023 08:16
andrebq
andrebq previously approved these changes Oct 23, 2023
Copy link
Contributor

@andrebq andrebq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, after offline discussion, the outcome is:

  • We keep the previous approach of not setting statuses, leaving it for Datadag to decided the actual state
  • We will discuss if it is better to have an explict method to select betwee: PAUSED, LIVE, KEEP_CURRENT_OR_PAUSED.

@azzmiks azzmiks merged commit 0a3e570 into master Oct 23, 2023
3 checks passed
@azzmiks azzmiks deleted the remove-default-paused-status branch October 23, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants