-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the test status not set by default #144
Conversation
713dfae
to
f3aa6ac
Compare
What happens if we create a test without a status? Will it throw an exception or the test will be created in a undefined state in Datadog? |
@andrebq If no status is provided in the test,
|
If we want to avoid changing something from Although, I wonder if it makes sense to always revert to What do you think? |
f3aa6ac
to
65e1a06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, after offline discussion, the outcome is:
- We keep the previous approach of
not setting statuses
, leaving it for Datadag to decided the actual state - We will discuss if it is better to have an explict method to select betwee:
PAUSED
,LIVE
,KEEP_CURRENT_OR_PAUSED
.
65e1a06
to
cd5721e
Compare
Scope
This PR changes the status behaviour for new implementations of Multi-step API and Browser tests: the
status
is no longer set aspaused
by default.