Improve the configuration set up #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunprakashind
force-pushed
the
task/improve-configuration-setup
branch
2 times, most recently
from
4da403c
to
8281f84
Compare
akhilbv
reviewed
Jan 9, 2023
arunprakashind
force-pushed
the
task/improve-configuration-setup
branch
2 times, most recently
from
1259585
to
d7e9cb9
Compare
akhilbv
previously approved these changes
Jan 9, 2023
friduchin
reviewed
Jan 9, 2023
src/test/kotlin/com/personio/synthetics/client/ConfigurationTest.kt
Outdated
Show resolved
Hide resolved
arunprakashind
force-pushed
the
task/improve-configuration-setup
branch
from
d7e9cb9
to
c21a16e
Compare
friduchin
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the configuration set up code and the unit tests