Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update substrate sdk version to polkadot v1.9 #24

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

NhoxxKienn
Copy link
Collaborator

This pull request updates the Substrate SDK version to Polkadot v1.9. By incorporating the latest Polkadot release (v1.9)

As reference: https://github.com/substrate-developer-hub/substrate-node-template

Changes made:

  • Update dependencies in Cargo.toml
  • Remove outdated interfaces Default for PK and add interface TypeInfo requirement in types.rs
  • Change required attributes in src/lib.rs (ex: Event to RuntimeEvent + add #[pallet::without_storage_info] for struct to specified unknown MaxEncodedLen parameters, add explicit call_index for each call).
  • Change weight.rs conversion from int to fit the new Weight package
  • In test, change expected error from InsufficientBalance to FundsUnvailabe for the case insufficient depositing.

Important: This PR must be reviewed first before reviewing the PR from Perun-Polkadot-Node because the Node uses a submodule of pallet inside.

Signed-off-by: Minh Huy Tran <huy@perun.network>
Signed-off-by: Minh Huy Tran <huy@perun.network>
Signed-off-by: Minh Huy Tran <huy@perun.network>
Signed-off-by: Minh Huy Tran <huy@perun.network>
Signed-off-by: Minh Huy Tran <huy@perun.network>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.46154% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.85%. Comparing base (9ef1476) to head (84d3e4b).

Files Patch % Lines
src/types.rs 95.00% 1 Missing ⚠️
tests/deposit.rs 91.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   98.68%   97.85%   -0.83%     
==========================================
  Files           9        9              
  Lines        1138     1213      +75     
==========================================
+ Hits         1123     1187      +64     
- Misses         15       26      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NhoxxKienn NhoxxKienn self-assigned this Apr 22, 2024
Cargo.toml Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
tests/unit.rs Outdated Show resolved Hide resolved
Signed-off-by: Minh Huy Tran <huy@perun.network>
Signed-off-by: Minh Huy Tran <huy@perun.network>
@NhoxxKienn NhoxxKienn merged commit af1f336 into master Apr 25, 2024
2 checks passed
@NhoxxKienn NhoxxKienn deleted the update_substrate branch April 25, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants