Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

dependencies #15

Merged
merged 3 commits into from

3 participants

@mikegolod

Hi, just spot your nice project today. Little changes in project setup and dependencies to make life of Spark end users easier.

mikegolod added some commits
@mikegolod mikegolod ignore idea project files/directory 9dfe901
@mikegolod mikegolod dependencies cleanup
Unused dependencies removed. End users of Spark don't need
slf4j-simple. They should use their preferrable logging implementation
(log4j, jcl, log back, etc).
4056798
@mikegolod mikegolod remove log4j config 4bbca10
@mikegolod

no one interested? :(

@kouphax

Does this pull request fix the fact that org.apache.commons#commons-io is not valid anymore. Seems it should be commons-io#commons-io. I had to modify the POM in my ivy2 cache to get this to work.

@mikegolod

yes, by removing it completely, cause current codebase doesn't really depend on it

@kouphax

Then in reply to "no one interested? :("

MEMEMEME

:)

@mikegolod

i wonder if author ever seen this req :(

@kouphax

One of the other issues sugests he is on paternity leave until August so I suspect he got his hands rather full :)

@perwendel
Owner

Hi,
As kouphax pointed out I'm on paternity leave but I'll try to have a look at this request as soon I get the time for it.
Best regards,
Per Wendel

@perwendel
Owner

Ok, a fairly small commmit and it looks good. Thanks for your contribution!

@perwendel perwendel merged commit 0e35d02 into from
@mikegolod

anytime, welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 3, 2012
  1. @mikegolod
  2. @mikegolod

    dependencies cleanup

    mikegolod authored
    Unused dependencies removed. End users of Spark don't need
    slf4j-simple. They should use their preferrable logging implementation
    (log4j, jcl, log back, etc).
  3. @mikegolod

    remove log4j config

    mikegolod authored
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 22 deletions.
  1. +4 −0 .gitignore
  2. +1 −13 pom.xml
  3. +0 −9 src/main/resources/log4j.properties
View
4 .gitignore
@@ -5,4 +5,8 @@ bin
.project
.classpath
.pdm
+.idea
+*.iml
+*.ipr
+*.iws
reports
View
14 pom.xml
@@ -25,13 +25,7 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
<version>1.6.4</version>
- </dependency>
-
- <dependency>
- <groupId>commons-logging</groupId>
- <artifactId>commons-logging</artifactId>
- <version>1.1.1</version>
- <scope>provided</scope>
+ <scope>provided</scope>
</dependency>
<dependency>
@@ -40,12 +34,6 @@
<version>${jetty.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-io</artifactId>
- <version>1.3.2</version>
- </dependency>
-
<!-- JUNIT DEPENDENCY FOR TESTING -->
<dependency>
<groupId>junit</groupId>
View
9 src/main/resources/log4j.properties
@@ -1,9 +0,0 @@
-log4j.appender.CONSOLE=org.apache.log4j.ConsoleAppender
-log4j.appender.CONSOLE.layout=org.apache.log4j.PatternLayout
-log4j.appender.CONSOLE.layout.conversionPattern=%d %-5p - %-26.26c{1} - %m\n
-
-# Specific
-log4j.logger.spark=DEBUG,CONSOLE
-log4j.logger.org.eclipse.jetty=WARN,CONSOLE
-
-# log4j.rootLogger=WARN,CONSOLE
Something went wrong with that request. Please try again.