Added parameters 'entryid' and 'attacheventidtokey' to eventlog section #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peschuster
requested changes
Dec 18, 2016
| @@ -119,8 +125,19 @@ private void OnEntryWritten(object sender, EntryWrittenEventArgs e) | |||
| if (!string.IsNullOrEmpty(this.category) && !this.category.Equals(e.Entry.Category, StringComparison.OrdinalIgnoreCase)) | |||
| return; | |||
|
|
|||
| if (this.eventid.HasValue && !this.eventid.Equals(e.Entry.EventID)) | |||
There was a problem hiding this comment.
EventID seems to be obsolete (see https://msdn.microsoft.com/en-us/library/system.diagnostics.eventlogentry.eventid.aspx). Could you change it to InstanceId? I think it should have the same meaning.
| var key = this.key; | ||
| if (this.attacheventidtokey) | ||
| { | ||
| key = string.Format("{0}.{1}", this.key, e.Entry.EventID); |
| this.channel.Report( | ||
| this.key.Replace("${type}", typeTranslation[e.Entry.EntryType]), | ||
| key.Replace("${type}", typeTranslation[e.Entry.EntryType]), |
There was a problem hiding this comment.
I'd suggest adding a call to .Replace("${eventId}"... here, instead of introducing the additional configuration option AttachEventIDToKey. That would be more flexible as well.
| <add | ||
| key="eventlog.IIS" | ||
| protocol="System" source="IIS-IISReset" entrytypes="Error, Warning, Information" | ||
| type="counter" eventid="3202" target="statsd" /> |
There was a problem hiding this comment.
I think this should be in the <eventlog> section.
peschuster
added a commit
that referenced
this pull request
Jan 28, 2017
- InstanceId instead of EventID (obsolete)
- InstanceId is of type long
- more generic replacement of ${eventId} in key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is my first contribution to this project :)
I needed some extra features on eventlog listener, so I've added them.
These two features can be enabled via new parameters on section:
eventid: Filter events to be sent to graphite based on their "EventID".
Let's say I need to trace how may times an IIS appPool is recycled manually. This is shown on Event Viewer as source "WAS" / EventID "5079", so I'd need to configure it like this:
attacheventidtokey: Send every different event type as a separate metric. Enabling this flag, the application will attach the "EventID" to the end of the key. This way you
Let's say I need to count all WAS' Error events. I'd need to configure it like this:
Hope you find this as useful as me :)