chore: switch benches to criterion plus MSRV bump to 1.56 #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
plus clippy fixes (needed for the bumped MSRV) |
tomtau
force-pushed
the
chore/criterion
branch
2 times, most recently
from
f599dbf
to
26ddf30
Compare
as per pest-parser#615 (comment) besides criterion, it is now possible to compile the `const_prec_climber` feature on stable, because `const_fn_trait_bound` was stabilized plus clippy fixes
CAD97
approved these changes
Jul 15, 2022
| @@ -7,7 +7,6 @@ | |||
| // option. All files in the project carrying such notice may not be copied, | |||
| // modified, or distributed except according to those terms. | |||
| #![no_std] | |||
| #![cfg_attr(feature = "const_prec_climber", feature(const_fn_trait_bound))] | |||
NoahTheDuke
reviewed
Jul 19, 2022
| @@ -22,7 +22,7 @@ jobs: | |||
| - name: Install Rust Stable | |||
| uses: actions-rs/toolchain@v1 | |||
| with: | |||
| toolchain: 1.51.0 # Pinned warnings | |||
| toolchain: 1.56.1 # Pinned warnings | |||
There was a problem hiding this comment.
Any particular reason to not bump to latest? I don't know best practices for Rust versions.
There was a problem hiding this comment.
It's meant as a sort of "LTS".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per #615 (comment)
besides criterion, it is now possible to compile the
const_prec_climberfeature on stable, becauseconst_fn_trait_boundwas stabilized