fix: migrated to 2018 edition #615
Conversation
closes pest-parser#300 the code was migrated via `cargo fix --edition` and the grammar benchmarks were rewritten to use `bencher` instead of the nightly test (so that they can be built on a stable version).
|
What is your rationale for migrating to the 2018 edition rather than 2021? |
|
@glyn I was originally planning 2021, but it seems the current minimal version on CI doesn't support it: https://github.com/pest-parser/pest/runs/7268848504?check_suite_focus=true hence I switched it to 2018. maybe good for @CAD97 to comment whether it's ok to bump up MSRV. |
|
IMO: don't bump MSRV for such a minor thing, the 2021 edition probably doesn't have anything to offer |
|
If we bump MSRV it should be in a separate patch. MSRV should ideally only be increased for a specific benefit; I think it's reasonable to set an MSRV of 1.56 for the For reference:
|
|
Thanks @CAD97 . I originally used criterion, but it failed on CI due to one of its dependencies requiring edition 2021, hence bencher. |
|
It should be fine to only run benchmarks/tests/examples on current stable rather than MSRV, so it shouldn't be a problem for them to have a higher MSRV. |
as per pest-parser#615 (comment) besides criterion, it is now possible to compile the `const_prec_climber` feature on stable, because `const_fn_trait_bound` was stabilized
as per pest-parser#615 (comment) besides criterion, it is now possible to compile the `const_prec_climber` feature on stable, because `const_fn_trait_bound` was stabilized plus clippy fixes
as per pest-parser#615 (comment) besides criterion, it is now possible to compile the `const_prec_climber` feature on stable, because `const_fn_trait_bound` was stabilized plus clippy fixes
as per pest-parser#615 (comment) besides criterion, it is now possible to compile the `const_prec_climber` feature on stable, because `const_fn_trait_bound` was stabilized plus clippy fixes
closes #300
the code was migrated via
cargo fix --editionand the grammar benchmarks were rewritten to use
bencherinstead of the nightly test (so that they can be built
on a stable version).