Merge pull request #1001 from faissaloux/fix-html-in-descriptions-or-…

…datasets Fix html in descriptions or datasets
pestphp · Nov 8, 2023 · 3c0d780 · 3c0d780
2 parents 0a680dd + 16768fc
commit 3c0d780
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 4 deletions.
diff --git a/src/Concerns/Testable.php b/src/Concerns/Testable.php
@@ -193,6 +193,7 @@ protected function setUp(): void
         $method = TestSuite::getInstance()->tests->get(self::$__filename)->getMethod($this->name());
 
         $description = $this->dataName() ? $method->description.' with '.$this->dataName() : $method->description;
+        $description = htmlspecialchars(html_entity_decode($description), ENT_NOQUOTES);
 
         if ($method->repetitions > 1) {
             $matches = [];

diff --git a/tests/.snapshots/success.txt b/tests/.snapshots/success.txt
@@ -1194,6 +1194,7 @@
   ✓ it show the correct description for mixed named and not-named datasets
   ✓ it shows the correct description for long texts with newlines
   ✓ it shows the correct description for arrays with many elements
+  ✓ it shows the correct description of datasets with html
 
    PASS  Tests\Unit\Expectations\OppositeExpectation
   ✓ it throw expectation failed exception with string argument
@@ -1352,4 +1353,4 @@
    WARN  Tests\Visual\Version
   - visual snapshot of help command output
 
-  Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 13 todos, 19 skipped, 962 passed (2280 assertions)
+  Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 13 todos, 19 skipped, 963 passed (2281 assertions)
diff --git a/tests/Unit/DatasetsTests.php b/tests/Unit/DatasetsTests.php
@@ -99,3 +99,13 @@
 
     expect($descriptions[0])->toBe('([1, 2, 3, …])');
 });
+
+it('shows the correct description of datasets with html', function () {
+    $descriptions = array_keys(DatasetsRepository::resolve([
+        [
+            '<div class="flex items-center"></div>',
+        ],
+    ], __FILE__));
+
+    expect($descriptions[0])->toBe('(\'<div class="flex items-center"></div>\')');
+});
diff --git a/tests/Unit/TestName.php b/tests/Unit/TestName.php
@@ -20,7 +20,7 @@
     '卜竹弓一十山' => '__pest_evaluable_卜竹弓一十山',
     'アゴデヸ' => '__pest_evaluable_アゴデヸ',
     '!p8VrB' => '__pest_evaluable__p8VrB',
-    '&xe6VeKWF#n4' => '__pest_evaluable__xe6VeKWF_n4',
+    '&amp;xe6VeKWF#n4' => '__pest_evaluable__amp_xe6VeKWF_n4',
     '%%HurHUnw7zM!' => '__pest_evaluable___HurHUnw7zM_',
     'rundeliekend' => '__pest_evaluable_rundeliekend',
     'g%%c!Jt9$fy#Kf' => '__pest_evaluable_g__c_Jt9_fy_Kf',
@@ -33,7 +33,7 @@
     'Каролин' => '__pest_evaluable_Каролин',
     'অ্যান্টার্কটিকা' => '__pest_evaluable_অ্যান্টার্কটিকা',
     'Frýdek-Místek"' => '__pest_evaluable_Frýdek_Místek_',
-    'Allingåbro&' => '__pest_evaluable_Allingåbro_',
+    'Allingåbro&amp;' => '__pest_evaluable_Allingåbro_amp_',
     'Κεντροαφρικανική Δημοκρατία' => '__pest_evaluable_Κεντροαφρικανική_Δημοκρατία',
     'آذربایجان غربی' => '__pest_evaluable_آذربایجان_غربی',
     'זימבבואה' => '__pest_evaluable_זימבבואה',

diff --git a/tests/Visual/Parallel.php b/tests/Visual/Parallel.php
@@ -16,7 +16,7 @@
 
 test('parallel', function () use ($run) {
     expect($run('--exclude-group=integration'))
-        ->toContain('Tests:    1 deprecated, 4 warnings, 5 incomplete, 2 notices, 13 todos, 15 skipped, 951 passed (2265 assertions)')
+        ->toContain('Tests:    1 deprecated, 4 warnings, 5 incomplete, 2 notices, 13 todos, 15 skipped, 952 passed (2266 assertions)')
         ->toContain('Parallel: 3 processes');
 })->skipOnWindows();