Fix html in descriptions or datasets #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunomaduro
requested changes
Nov 7, 2023
| @@ -20,7 +20,7 @@ | |||
| '卜竹弓一十山' => '__pest_evaluable_卜竹弓一十山', | |||
| 'アゴデヸ' => '__pest_evaluable_アゴデヸ', | |||
| '!p8VrB' => '__pest_evaluable__p8VrB', | |||
| '&xe6VeKWF#n4' => '__pest_evaluable__xe6VeKWF_n4', | |||
| '&xe6VeKWF#n4' => '__pest_evaluable__amp_xe6VeKWF_n4', | |||
There was a problem hiding this comment.
It's because $__latestDescription changes here after changing the description HTML tags to HTML entities.
pest/src/Concerns/Testable.php
Line 212 in 0a680dd
| @@ -33,7 +33,7 @@ | |||
| 'Каролин' => '__pest_evaluable_Каролин', | |||
| 'অ্যান্টার্কটিকা' => '__pest_evaluable_অ্যান্টার্কটিকা', | |||
| 'Frýdek-Místek"' => '__pest_evaluable_Frýdek_Místek_', | |||
| 'Allingåbro&' => '__pest_evaluable_Allingåbro_', | |||
| 'Allingåbro&' => '__pest_evaluable_Allingåbro_amp_', | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
Termwind raises a StyleNotFound exception when a test dataset or description includes html tags with class attribute, as Termwind tries to style it as html element but the class is not supported.
Example:
If the test desciption doesn't include html tags with class attribute, Termwind will raise the same exception for dataset.
I have converted html tags into HTML entities so that Termwind will treat it as normal text. And the result will shows as written in the test description or Dataset:
PS: Same thing applies on
describe().