feat: phpunit 10 support #263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukeraymonddowning @owenvoke Any of you would like to spend time on this one? Won't wanna lie, this may take some time to investigate... |
|
I might have another go at it, should also be easier to manage now that those core plugins have been merged. 👍🏻 |
# Conflicts: # composer.json # src/Actions/LoadStructure.php
owenvoke
reviewed
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an upcoming major version bump for PHPUnit. This seems to contain some breaking changes that affect Pest.
Plugins
Expectations Plugin: pestphp/pest-plugin-expectations#5.
Current issues
Custom
TestSuiteLoaderdeprecationI think that this is now indirectly causing issues as it now seems to expect any selected file in the testsuite directory to contain a PHP class. So if the testsuite directory is set to
tests/andsuffix=".php"(as per our current suite), it tries loading all files that are pascal case as a class. This means thattests/Autoload.phpis loaded as a class, as are all the datasets, etc.This basically means that all Pest-syntax tests will fail, as they don't contain a class in the files. 😬