-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Add ability to run tests in a separate process #285
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e9d2c9b
Add tests for process in isolation
dingo-d 2aa42d6
Remove validation for process isolation
dingo-d 76107c6
Remove validation for process isolation config
dingo-d dfcd68e
Add method to run test in a separate process
dingo-d 320c283
Add methods to set test case in isolation and preserving global state
dingo-d 51f146d
Fix test description
dingo-d bd35cac
Fix lint issues
dingo-d 032a07d
Set correct flags
dingo-d 48dec74
Trying out writing the temp file for the separate process
dingo-d 3268ddc
Add a clenup of temp files
dingo-d c413086
Create temp file only for tests which should run in isolation
dingo-d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
<?php | ||
|
||
function cacheable(): int | ||
{ | ||
static $value; | ||
|
||
if ($value !== null) { | ||
return $value; | ||
} | ||
|
||
if (defined('ISOLATED') && ISOLATED) { | ||
$value = 1; | ||
} else { | ||
$value = 2; | ||
} | ||
|
||
return $value; | ||
} | ||
|
||
test('Set cacheable function', function () { | ||
define('ISOLATED', true); | ||
|
||
$value = cacheable(); | ||
|
||
$this->assertSame(1, $value); | ||
}); | ||
|
||
test('Cached value will still be set', function () { | ||
$value = cacheable(); | ||
|
||
$this->assertSame(1, $value); | ||
}); | ||
|
||
test('Cacheable function should return a different value because of process isolation', function () { | ||
if (!defined('ISOLATED')) { | ||
define('ISOLATED', false); | ||
} | ||
|
||
$value = cacheable(); | ||
|
||
$this->assertSame(2, $value); | ||
})->runInSeparateProcess(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really need all this code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is related to the comment
The issue is that when using eval, the reflection won't return the intended filename (by design). This is a workaround (attempt at least).