Change Bytes read

[izavala]

Working on getting second failing test to pass. Should have this done soon, will set the tcp port to try and connect after the connection has closed and check to make sure an error is signaled as the port should refuse a connection.

[izavala]

Test are passing in Visual Studio but seem to be failing both the Linux and Windows, need to look into why both test are failing here

[izavala]

Looked through the logs and it looks like the test below is now failing, need to look into why it's failing:

akkadotnet-healthcheck/src/Akka.HealthCheck.Tests/AkkaHealthCheckIntegrationSpec.cs

Lines 44 to 84 in 64b56a0

	[Fact(DisplayName = "End2End: should load complete custom Akka.HealthCheck config")]
	public async Task Should_load_custom_HealthCheck_system_correctly()
	{
	// forces the plugin to load
	var healthCheck = AkkaHealthCheck.For(Sys);
	var readinessSubscriber = CreateTestProbe();
	var livenessSubscriber = CreateTestProbe();
	healthCheck.LivenessProbe.Tell(new SubscribeToLiveness(livenessSubscriber));
	healthCheck.ReadinessProbe.Tell(new SubscribeToReadiness(readinessSubscriber));
	livenessSubscriber.ExpectMsg<LivenessStatus>().IsLive.Should().BeTrue();
	readinessSubscriber.ExpectMsg<ReadinessStatus>().IsReady.Should().BeTrue();
	var filePath = healthCheck.Settings.ReadinessTransportSettings.As<FileTransportSettings>().FilePath;
	var tcpPort = healthCheck.Settings.LivenessTransportSettings.As<SocketTransportSettings>().Port;
	// check to see that our probes are up and running using the supplied transports
	AwaitCondition(() => File.Exists(filePath));
	var tcpClient = new TcpClient(AddressFamily.InterNetworkV6);
	await tcpClient.ConnectAsync(IPAddress.IPv6Loopback, tcpPort);
	// force shutdown of the ActorSystem and verify that probes are stopped
	await Sys.Terminate();
	// Readiness probe should not exist
	AwaitCondition(() => !File.Exists(filePath));
	// liveness probe should be disconnected
	try
	{
	var bytesRead = await tcpClient.GetStream().ReadAsync(new byte[10], 0, 10);
	bytesRead.Should().Be(0);
	}
	catch
	{
	}
	tcpClient.Connected.Should().BeFalse();
	}
	}

[izavala]

When we are testing to see if we are still connected to the TCP port, we are not attempting to interact with the socket so it seems it may not be updating the status.

akkadotnet-healthcheck/src/Akka.HealthCheck.Tests/AkkaHealthCheckIntegrationSpec.cs

Lines 67 to 82 in 64b56a0

	await Sys.Terminate();
	// Readiness probe should not exist
	AwaitCondition(() => !File.Exists(filePath));
	// liveness probe should be disconnected
	try
	{
	var bytesRead = await tcpClient.GetStream().ReadAsync(new byte[10], 0, 10);
	bytesRead.Should().Be(0);
	}
	catch
	{
	}
	tcpClient.Connected.Should().BeFalse();

[Aaronontheweb]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[izavala]

/AzurePipelines run

[Aaronontheweb]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[Aaronontheweb]

Looks good to me!

[Aaronontheweb]

LGTM

[Aaronontheweb]

Good