-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Bytes read #25
Conversation
Test are passing in Visual Studio but seem to be failing both the Linux and Windows, need to look into why both test are failing here |
Looked through the logs and it looks like the test below is now failing, need to look into why it's failing: akkadotnet-healthcheck/src/Akka.HealthCheck.Tests/AkkaHealthCheckIntegrationSpec.cs Lines 44 to 84 in 64b56a0
|
When we are testing to see if we are still connected to the TCP port, we are not attempting to interact with the socket so it seems it may not be updating the status. akkadotnet-healthcheck/src/Akka.HealthCheck.Tests/AkkaHealthCheckIntegrationSpec.cs Lines 67 to 82 in 64b56a0
|
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
/AzurePipelines run |
1 similar comment
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
||
public static Config GetConfig() | ||
{ | ||
var PortNumber = ThreadLocalRandom.Current.Next(10000, 64000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
tcpClient.Connected.Should().BeFalse(); | ||
//Second client should not be able to connect as socket has been closed | ||
AwaitCondition(()=> !tcpClient2.Connected); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
Working on getting second failing test to pass. Should have this done soon, will set the tcp port to try and connect after the connection has closed and check to make sure an error is signaled as the port should refuse a connection.