Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to return non-zero exit code when NBench or XUnit tests fail #86

Closed
Aaronontheweb opened this issue Feb 13, 2019 · 0 comments · Fixed by #87
Closed

Need to return non-zero exit code when NBench or XUnit tests fail #86

Aaronontheweb opened this issue Feb 13, 2019 · 0 comments · Fixed by #87
Labels
bug ci Continuous Integration FAKE FAKE F# scripting issues
Milestone
v0.4.3 Release

Comments

@Aaronontheweb
Copy link
Member

Current the FAKE script will not report errors at the end of the build in the event that either of the XUnit or NBench steps fail. This behavior worked fine on TeamCity since it could still detect test failures, but it does not work well on Azure Pipelines or other CI systems which rely on the exit code.
@Aaronontheweb Aaronontheweb added bug ci Continuous Integration FAKE FAKE F# scripting issues labels Feb 13, 2019
@Aaronontheweb Aaronontheweb added this to the v0.4.3 Release milestone Feb 13, 2019
Aaronontheweb added a commit to Aaronontheweb/petabridge-dotnet-new that referenced this issue Feb 13, 2019
@Aaronontheweb
close petabridge#86 - ensured that NBench and XUnit failures return e…
4e11b11 
…rror code
@Aaronontheweb Aaronontheweb mentioned this issue Feb 13, 2019
Merged
Aaronontheweb added a commit that referenced this issue Feb 17, 2019
@Aaronontheweb
close #86 - ensured that NBench and XUnit failures return error code (#…
4575551 
…87)
This was referenced Feb 17, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ci Continuous Integration FAKE FAKE F# scripting issues
Projects
None yet
Milestone
v0.4.3 Release
Development

Successfully merging a pull request may close this issue.

ensured that NBench and XUnit failures return error code Aaronontheweb/petabridge-dotnet-new
1 participant
@Aaronontheweb