Skip to content
This repository has been archived by the owner on Jul 30, 2020. It is now read-only.

Platform App #7

Closed
wants to merge 43 commits into from
Closed

Platform App #7

wants to merge 43 commits into from

Conversation

IgorMinar
Copy link

No description provided.

ebidel and others added 30 commits May 3, 2012 18:18
I had to move almost all the logic into the root controller, which is not nice, but I will refractor it into a service later...
the app is still broken due to lawnchair calls
@ebidel
Copy link
Collaborator

ebidel commented Jun 28, 2012

Should this be instead merged into the angularjs-refactored branch? @petele ?

@IgorMinar
Copy link
Author

the angularjs-refactored is a webapp. this branch is a platform app. the two are architecturally very very different (background pages, CSP, sandboxed page). I suggest that you keep both versions.

we should also migrate some fixes and refactorings from the platform-app to the web-app.

@ebidel
Copy link
Collaborator

ebidel commented Jun 28, 2012

It says you want to merge into petele:master...? Is github being dumb or am I?

@IgorMinar
Copy link
Author

I think master is the default target for PR on github. We need to figure out how we want the source code to be organized. A separate repo might be a better way to do it. Let's figure that out post IO.

In the meantime I sent this PR so you guys have access to the code. Just fetch it from my repo and do some goodness with it.

@ebidel
Copy link
Collaborator

ebidel commented Jul 4, 2012

As discussed in email, I've setup a repo under the GoogleChrome org. Let's use that rather than updating the app here. Too many copies makes @ebidel turn into The Incredible Hulk

@ebidel ebidel closed this Jul 4, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants