Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fibre channel support #18

Merged
merged 4 commits into from
Jul 23, 2017
Merged

Add fibre channel support #18

merged 4 commits into from
Jul 23, 2017

Conversation

peter-wangxu
Copy link
Owner

@peter-wangxu peter-wangxu commented Jun 15, 2017

  • ConnectVolume for fc protocol.
  • Efficient fc host rescan instead of wildcard rescan.

@codecov
Copy link

codecov bot commented Jun 24, 2017

Codecov Report

Merging #18 into master will decrease coverage by 3.11%.
The diff coverage is 83.43%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #18      +/-   ##
=========================================
- Coverage   82.32%   79.2%   -3.12%     
=========================================
  Files          12      14       +2     
  Lines         826    1082     +256     
=========================================
+ Hits          680     857     +177     
- Misses        122     193      +71     
- Partials       24      32       +8
Impacted Files Coverage Δ
client/iscsi.go 100% <100%> (ø) ⬆️
linux/fc.go 90.32% <100%> (-0.31%) ⬇️
linux/scsi.go 91.54% <100%> (-2.13%) ⬇️
cmd/app.go 100% <100%> (ø) ⬆️
client/base.go 76.13% <70.76%> (-15.17%) ⬇️
util/common.go 37.25% <80%> (ø)
connector/fibre_channel.go 80.3% <80.3%> (ø)
connector/iscsi.go 80.3% <85.71%> (-0.11%) ⬇️
connector/base.go 84.31% <87.23%> (+17.64%) ⬆️
model/model.go 82.48% <87.69%> (+0.09%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1e3fa7...9ac3184. Read the comment docs.

@peter-wangxu peter-wangxu force-pushed the add_fc_support branch 5 times, most recently from bdd1486 to b7e2987 Compare June 27, 2017 14:42
* ConnectVolume for fc protocol.
* Efficient fc host rescan instead of wildcard rescan.
@peter-wangxu peter-wangxu merged commit 4634330 into master Jul 23, 2017
@peter-wangxu peter-wangxu deleted the add_fc_support branch July 23, 2017 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant