New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added param to add custom key generator function #10

Merged
merged 2 commits into from Nov 3, 2018

Conversation

Projects
None yet
2 participants
@jaumebecks
Contributor

jaumebecks commented Nov 2, 2018

Hi! This PR grants the possibility to add a custom key generator function to the base functionality.

This is my first PR ever, so please let me know your feedback about it. Thanks :)

@codecov

This comment has been minimized.

codecov bot commented Nov 2, 2018

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #10   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          37     39    +2     
=====================================
+ Hits           37     39    +2
Impacted Files Coverage Δ
src/cache_memoize/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939363f...5fe91f8. Read the comment docs.

Jaume Jiménez
@jaumebecks

This comment has been minimized.

Contributor

jaumebecks commented Nov 2, 2018

I initially forgot the tests u.u'. All feedback is welcome, thanks @peterbe

@peterbe

peterbe approved these changes Nov 3, 2018

Gorgeous!

@peterbe peterbe merged commit 19b68a4 into peterbe:master Nov 3, 2018

3 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 939363f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

peterbe added a commit to mozilla-services/tecken that referenced this pull request Nov 3, 2018

Update django-cache-memoize to 0.1.3 (#1291)
This PR updates [django-cache-memoize](https://pypi.org/project/django-cache-memoize) from **0.1.2** to **0.1.3**.



<details>
  <summary>Changelog</summary>
  
  
   ### 0.1.3
   ```
   - Ability to pass in your own custom cache-key callable function.
  Thanks jaumebecks
  `pull10 &lt;https://github.com/peterbe/django-cache-memoize/pull/10&gt;`_
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/django-cache-memoize
  - Changelog: https://pyup.io/changelogs/django-cache-memoize/
  - Repo: https://github.com/peterbe/django-cache-memoize
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment