-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests to support Django versions 3.1 and 3.2. #47
Conversation
Can you merge in the latest upstream |
Will do! I only have one version of python installed in my virtualenv locally so wanted to use CI to run the tests anyway - thank you for #48 ! |
@peterbe looks like I need approval to get the workflow to run? If the tests don't pass I can take a look at what updates need making later this afternoon. |
@peterbe CI passed but it appears the tests aren't running properly - on my local I get output like |
I created a virtualenv, locally, based on Py 3.8. Now I can type:
and then all tests pass. And it says But if I type:
tests fail. And that's where your challenge starts :) |
As of #49 try to merge in |
acd00f8
to
3f5bab5
Compare
@peterbe apparently I still need approval for the workflow to rerun :/. |
@peterbe looks like they're running on my fork and failing so I can dig in and fix those issues and will ping you when I need that approval! |
10a7d0b
to
3abe223
Compare
Supports Python versions 3.5 - 3.9. Fixes peterbe#44.
96aaa61
to
e329c2b
Compare
e329c2b
to
63368c4
Compare
@peterbe would you approve the workflow? Seems there was only one small fix to make things work for Django 3.1 and 3.2, and then another to make PyPy tests work. I believe this should pass CI! |
Now you're no longer a first-time contributor! Thanks! |
Supports Python versions 3.5 - 3.9.
Fixes #44.