Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to support Django versions 3.1 and 3.2. #47

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

YPCrumble
Copy link
Contributor

Supports Python versions 3.5 - 3.9.
Fixes #44.

@peterbe
Copy link
Owner

peterbe commented Jun 30, 2021

Can you merge in the latest upstream master into this branch now that #48 has landed.

@YPCrumble
Copy link
Contributor Author

Will do! I only have one version of python installed in my virtualenv locally so wanted to use CI to run the tests anyway - thank you for #48 !

@YPCrumble
Copy link
Contributor Author

@peterbe looks like I need approval to get the workflow to run? If the tests don't pass I can take a look at what updates need making later this afternoon.

@YPCrumble YPCrumble changed the title [WIP] Update code to support Django versions 3.1 and 3.2. Update tests to support Django versions 3.1 and 3.2. Jun 30, 2021
@YPCrumble
Copy link
Contributor Author

@peterbe CI passed but it appears the tests aren't running properly - on my local I get output like Ran 18 tests in xxxx seconds OK and that doesn't seem to be showing up in CI - also the CI suite appears to be running way too quickly to be actually running the tests.

@peterbe
Copy link
Owner

peterbe commented Jun 30, 2021

I created a virtualenv, locally, based on Py 3.8. Now I can type:

pip install -U pip wheel tox
tox -e py38-dj22

and then all tests pass. And it says Ran 18 tests in 0.024s.

But if I type:

py38-dj32

tests fail. And that's where your challenge starts :)

@peterbe
Copy link
Owner

peterbe commented Jul 1, 2021

As of #49 try to merge in master again and retry.

@YPCrumble
Copy link
Contributor Author

@peterbe apparently I still need approval for the workflow to rerun :/.

@YPCrumble
Copy link
Contributor Author

@peterbe looks like they're running on my fork and failing so I can dig in and fix those issues and will ping you when I need that approval!

@YPCrumble YPCrumble force-pushed the feature/django-updates branch 2 times, most recently from 10a7d0b to 3abe223 Compare July 1, 2021 14:19
Supports Python versions 3.5 - 3.9.
Fixes peterbe#44.
@YPCrumble YPCrumble force-pushed the feature/django-updates branch 3 times, most recently from 96aaa61 to e329c2b Compare July 1, 2021 15:55
@YPCrumble
Copy link
Contributor Author

@peterbe would you approve the workflow? Seems there was only one small fix to make things work for Django 3.1 and 3.2, and then another to make PyPy tests work. I believe this should pass CI!

@peterbe peterbe merged commit d36f16c into peterbe:master Jul 2, 2021
@peterbe
Copy link
Owner

peterbe commented Jul 2, 2021

@peterbe would you approve the workflow? Seems there was only one small fix to make things work for Django 3.1 and 3.2, and then another to make PyPy tests work. I believe this should pass CI!

Now you're no longer a first-time contributor! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Django 3.1
2 participants