Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test updates, python 3.6, django 1.11 #42

Closed
wants to merge 1 commit into from
Closed

Test updates, python 3.6, django 1.11 #42

wants to merge 1 commit into from

Conversation

scop
Copy link
Contributor

@scop scop commented Aug 11, 2018

No description provided.

peterbe
peterbe reviewed Aug 12, 2018
View reviewed changes
tox.ini

[testenv:py36_dj111]
basepython = python3.6
commands = pip install --ignore-installed 'django>= 1.11, <1.12'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it not work in Django 2.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, I just wanted to check whether it does in 1.11 and python 3.6 :)

@peterbe peterbe mentioned this pull request Aug 13, 2018
Merged
@peterbe
Copy link
Owner

peterbe commented Aug 13, 2018

Thank you so much for your contribution!
I made a bigger PR that changed not only this but also fixed the tests to cover Django 1.8 and 2.1.

@peterbe peterbe closed this Aug 13, 2018
peterbe pushed a commit that referenced this pull request Aug 13, 2018
django 1.11, 2.0 and python 3.6 (#43)
8e7e73a 
Fixes #40 
Fixes #43 
Fixes #42 
Fixes #41
@scop scop deleted the test-updates branch August 15, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbe peterbe peterbe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scop @peterbe