Skip to content

Commit

Permalink
lintcheck tests too (#151)
Browse files Browse the repository at this point in the history
  • Loading branch information
Peter Bengtsson committed Feb 20, 2018
1 parent 9ba22da commit 2814ea5
Show file tree
Hide file tree
Showing 2 changed files with 106 additions and 106 deletions.
2 changes: 1 addition & 1 deletion scripts/lintcheck.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ See https://prettier.io/docs/en/editors.html#content
exit 1
}

prettier --list-different "src/*.js" "bin/*.js" || error
prettier --list-different "src/*.js" "tests/*.js" "bin/*.js" || error
210 changes: 105 additions & 105 deletions tests/main.test.js
View file
Original file line number Diff line number Diff line change
@@ -1,165 +1,165 @@
const fastify = require('fastify')()
const path = require('path')
const puppeteer = require('puppeteer')
const minimalcss = require('../index')
const fastify = require('fastify')();
const path = require('path');
const puppeteer = require('puppeteer');
const minimalcss = require('../index');

fastify.register(require('fastify-static'), {
root: path.join(__dirname, 'examples')
})
});

// Important that the URL doesn't end with .css
fastify.get('/307-css', (req, reply) => {
reply.redirect(307, '/redirected.css')
})
reply.redirect(307, '/redirected.css');
});

fastify.get('/307.html', (req, reply) => {
reply.redirect(307, '/redirected.html')
})
reply.redirect(307, '/redirected.html');
});

let browser
let browser;

const runMinimalcss = (path, options = {}) => {
options.browser = browser
options.urls = [`http://localhost:3000/${path}.html`]
return minimalcss.minimize(options)
}
options.browser = browser;
options.urls = [`http://localhost:3000/${path}.html`];
return minimalcss.minimize(options);
};

beforeAll(async () => {
await fastify.listen(3000)
await fastify.listen(3000);
browser = await puppeteer.launch({
args: ['--no-sandbox', '--disable-setuid-sandbox']
})
})
});
});

afterAll(async () => {
await fastify.close()
await browser.close()
})
await fastify.close();
await browser.close();
});

test('handles relative paths', async () => {
const { finalCss } = await runMinimalcss('css-relative-path')
expect(finalCss).toMatch('background:url(/images/small.jpg)')
expect(finalCss).toMatch('background-image:url(/images/small.jpg)')
const { finalCss } = await runMinimalcss('css-relative-path');
expect(finalCss).toMatch('background:url(/images/small.jpg)');
expect(finalCss).toMatch('background-image:url(/images/small.jpg)');
expect(finalCss).toMatch(
'background:url(http://127.0.0.1:3000/images/small.jpg)'
)
);
expect(finalCss).toMatch(
'background-image:url(http://127.0.0.1:3000/images/small.jpg)'
)
})
);
});

test('handles JS errors', async () => {
expect.assertions(1)
expect.assertions(1);
try {
await runMinimalcss('jserror')
await runMinimalcss('jserror');
} catch (e) {
expect(e.message).toMatch('Error: unhandled')
expect(e.message).toMatch('Error: unhandled');
}
})
});

test('cares only about external CSS files', async () => {
const { finalCss } = await runMinimalcss('css-in-js')
expect(finalCss).toEqual('.external{color:red}')
})
const { finalCss } = await runMinimalcss('css-in-js');
expect(finalCss).toEqual('.external{color:red}');
});

test('handles 404 CSS file', async () => {
expect.assertions(1)
expect.assertions(1);
try {
await runMinimalcss('404css')
await runMinimalcss('404css');
} catch (e) {
expect(e.message).toMatch('404 on')
expect(e.message).toMatch('404 on');
}
})
});

test('media queries print removed', async () => {
const { finalCss } = await runMinimalcss('media-queries-print')
expect(finalCss).toEqual('')
})
const { finalCss } = await runMinimalcss('media-queries-print');
expect(finalCss).toEqual('');
});

test('removes unused @keyframes', async () => {
const { finalCss } = await runMinimalcss('keyframe-removes')
expect(finalCss).toEqual('')
})
const { finalCss } = await runMinimalcss('keyframe-removes');
expect(finalCss).toEqual('');
});

test('leaves used @keyframes', async () => {
const { finalCss } = await runMinimalcss('keyframe-leaves')
expect(finalCss).toMatch('@keyframes RotateSlot')
})
const { finalCss } = await runMinimalcss('keyframe-leaves');
expect(finalCss).toMatch('@keyframes RotateSlot');
});

test.skip('leaves used inline @keyframes', async () => {
const { finalCss } = await runMinimalcss('keyframe-removes-inline')
expect(finalCss).toMatch('@keyframes RotateSlot')
})
const { finalCss } = await runMinimalcss('keyframe-removes-inline');
expect(finalCss).toMatch('@keyframes RotateSlot');
});

test('removes unused @fontface', async () => {
const { finalCss } = await runMinimalcss('fontface-removes')
expect(finalCss).toEqual('')
})
const { finalCss } = await runMinimalcss('fontface-removes');
expect(finalCss).toEqual('');
});

test('leaves used @fontface', async () => {
const { finalCss } = await runMinimalcss('fontface-leaves')
expect(finalCss).toMatch("@font-face{font-family:'Lato';")
})
const { finalCss } = await runMinimalcss('fontface-leaves');
expect(finalCss).toMatch("@font-face{font-family:'Lato';");
});

test.skip('leaves used inline @fontface', async () => {
const { finalCss } = await runMinimalcss('fontface-removes-inline')
expect(finalCss).toMatch("@font-face{font-family:'Lato';")
})
const { finalCss } = await runMinimalcss('fontface-removes-inline');
expect(finalCss).toMatch("@font-face{font-family:'Lato';");
});

test('leaves used pseudo classes', async () => {
const { finalCss } = await runMinimalcss('pseudo-classes')
expect(finalCss).toMatch('a:active')
expect(finalCss).toMatch('a:focus')
expect(finalCss).toMatch('a:hover')
expect(finalCss).toMatch('a:visited')
expect(finalCss).toMatch('input:disabled')
})
const { finalCss } = await runMinimalcss('pseudo-classes');
expect(finalCss).toMatch('a:active');
expect(finalCss).toMatch('a:focus');
expect(finalCss).toMatch('a:hover');
expect(finalCss).toMatch('a:visited');
expect(finalCss).toMatch('input:disabled');
});

test('media queries', async () => {
const { finalCss } = await runMinimalcss('media-queries')
expect(finalCss).toMatch('@media only screen and (min-device-width:414px)')
expect(finalCss).toMatch('@media only screen and (min-device-width:375px)')
})
const { finalCss } = await runMinimalcss('media-queries');
expect(finalCss).toMatch('@media only screen and (min-device-width:414px)');
expect(finalCss).toMatch('@media only screen and (min-device-width:375px)');
});

test('evaluate DOM multiple times', async () => {
const { finalCss } = await runMinimalcss('evaluate-dom-multiple-times')
expect(finalCss).toMatch('.SomeSelector')
expect(finalCss).toMatch('.OtherSelector')
})
const { finalCss } = await runMinimalcss('evaluate-dom-multiple-times');
expect(finalCss).toMatch('.SomeSelector');
expect(finalCss).toMatch('.OtherSelector');
});

test('form elements', async () => {
const { finalCss } = await runMinimalcss('form-elements')
expect(finalCss).toMatch('input[type=radio]:checked')
expect(finalCss).toMatch('input[type=checkbox]:checked')
expect(finalCss).toMatch('option:selected')
})
const { finalCss } = await runMinimalcss('form-elements');
expect(finalCss).toMatch('input[type=radio]:checked');
expect(finalCss).toMatch('input[type=checkbox]:checked');
expect(finalCss).toMatch('option:selected');
});

test('handles 307 CSS file', async () => {
const { finalCss } = await runMinimalcss('307css')
expect(finalCss).toEqual('p{color:violet}')
})
const { finalCss } = await runMinimalcss('307css');
expect(finalCss).toEqual('p{color:violet}');
});

test('handles 307 HTML file', async () => {
const { finalCss } = await runMinimalcss('307')
expect(finalCss).toEqual('p{color:violet}')
})
const { finalCss } = await runMinimalcss('307');
expect(finalCss).toEqual('p{color:violet}');
});

test("deliberately skipped .css shouldn't error", async () => {
const { finalCss } = await runMinimalcss('skippable-stylesheets', {
skippable: request => {
return request.url().search(/must-skip.css/) > -1
return request.url().search(/must-skip.css/) > -1;
}
})
expect(finalCss).toEqual('p{color:brown}')
})
});
expect(finalCss).toEqual('p{color:brown}');
});

test('order matters in multiple style sheets', async () => {
// In inheritance.html it references two .css files. The
// second one overrides the first one. But it's not a 100% overlap,
// as the first one has some rules of its own.
const { finalCss } = await runMinimalcss('inheritance')
expect(finalCss).toEqual('p{color:violet;font-size:16px;font-style:italic}')
})
const { finalCss } = await runMinimalcss('inheritance');
expect(finalCss).toEqual('p{color:violet;font-size:16px;font-style:italic}');
});

test('order matters in badly repeated style sheets', async () => {
// In repeated-badly.html it references two .css files. One
Expand All @@ -176,23 +176,23 @@ test('order matters in badly repeated style sheets', async () => {
// should cope and not choke.
// If you open repeated.html in a browser, the rules
// from repeated-second.css should decide lastly.
const { finalCss } = await runMinimalcss('repeated')
expect(finalCss).toEqual('p{color:violet;font-size:16px;font-style:italic}')
})
const { finalCss } = await runMinimalcss('repeated');
expect(finalCss).toEqual('p{color:violet;font-size:16px;font-style:italic}');
});

test.skip('handles css variables', async () => {
const { finalCss } = await runMinimalcss('css-variables')
expect(finalCss).toMatch('--main-bg-color:')
expect(finalCss).not.toMatch('--unused-color:')
})
const { finalCss } = await runMinimalcss('css-variables');
expect(finalCss).toMatch('--main-bg-color:');
expect(finalCss).not.toMatch('--unused-color:');
});

test('handles vendor prefixed properties', async () => {
const { finalCss } = await runMinimalcss('vendor-prefixes')
expect(finalCss).toMatch('-webkit-transition')
expect(finalCss).toMatch('abracadabra')
})
const { finalCss } = await runMinimalcss('vendor-prefixes');
expect(finalCss).toMatch('-webkit-transition');
expect(finalCss).toMatch('abracadabra');
});

test('leaves GET params in urls', async () => {
const { finalCss } = await runMinimalcss('get-params-in-url')
expect(finalCss).toMatch('/images/small.jpg?a=b')
})
const { finalCss } = await runMinimalcss('get-params-in-url');
expect(finalCss).toMatch('/images/small.jpg?a=b');
});

0 comments on commit 2814ea5

Please sign in to comment.