Add matrix mean method #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| SETUP_FUNCTION(Matrix) | ||
|
|
||
| cv::Scalar means = cv::mean(self->mat); | ||
| v8::Local<v8::Array> arr = Nan::New<Array>(3); |
There was a problem hiding this comment.
It would be nice to not assume a 3 channel matrix here, can we determine the number of channels in the src matrix and return that many means?
There was a problem hiding this comment.
Means always return a 3 element scalar irrespective of 1-3 channels in an image. If there is only 1 channel for example then the first element in the only valid value.
There was a problem hiding this comment.
Actually means return a 4 element scalar and not 3. The MeanWithMask example I followed is incorrect too. Let me fix it to return 4 elements.
|
Lgtm, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mvines ?
@peterbraden ?
I see there is a
meanWithMaskmethod already available. Ideally there should only be onemeanmethod with an optional argument of mask. There are a bunch of other such withMask methods so may be as a separate PR I would consolidate them.