Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused imports on EKF.py #413

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FelipeCybis
Copy link

Indeed, in the latest scipy release (1.12.0), they removed the, already deprecated, scipy.randn function. (The deprecated warning said they would remove at 2.0.0, but well...).

In robotics-toolbox-python there was one place where from scipy import randn was called: the roboticstoolbox/mobile/EKF.py but it was not used. Instead of limiting scipy<1.12.0, I removed the unused dependency (and a few others in the same file).

@kingjin94
Copy link

Second this MR as it is currently breaking the normal installation and usage of the toolbox 👍

@FelipeCybis
Copy link
Author

@petercorke @jhavl Sorry to bother, but could you guys have a look at this? scipy is a big package and, currently, we cannot use the latest version of it with robotics-toolbox-python :)

@Tobias-Fischer
Copy link

Can confirm that this is causing issues on conda-forge as well ..

@cpieringer
Copy link

Hi @FelipeCybis, do you know if your pull request is in the latest release of the toolbox? I am experimenting the exact error you all describe in the issue. Best.

@FelipeCybis
Copy link
Author

Hi @FelipeCybis, do you know if your pull request is in the latest release of the toolbox? I am experimenting the exact error you all describe in the issue. Best.

Yep, it should be. You can see the last commit in main is on my fork directly before my fix.

@seanjaffe1
Copy link

Thanks for fixing this, @FelipeCybis. @petercorke @jhavl should definitely merge this pull request, so the package can be used with the latest version of scipy

@hubble14567
Copy link

I have the same issue on up-to-date Ros2 humble. This is very simple and fixes everything.

@ntorresalberto
Copy link

Please merge this.

@TJMolnar
Copy link

TJMolnar commented May 21, 2024

@petercorke @jhavl Bumping this again. This is a critical bug with an easy fix, please merge asap.

EDIT: I can see this change has been made already in 2731430 , please disregard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import Error: randn from scripy
8 participants