Skip to content

Commit

Permalink
Merge pull request #419 from phlipper/sasl-ci
Browse files Browse the repository at this point in the history
Support SASL tests on Travis CI
  • Loading branch information
mperham committed Jan 7, 2014
2 parents acb1ff3 + 31f094a commit f5d9963
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
9 changes: 6 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ gemfile:
matrix:
allow_failures:
- rvm: rbx
branches:
only:
- master
env: JRUBY_OPTS='--1.9'
before_install:
- sudo apt-get -y remove memcached
- sudo apt-get -y install software-properties-common
- echo "yes" | sudo add-apt-repository ppa:travis-ci/memcached-sasl
- sudo apt-get update
- sudo apt-get install -y memcached=1.4.13-0ubuntu2+travis1
4 changes: 0 additions & 4 deletions test/helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,4 @@ def with_actionpack
require 'action_controller'
yield
end

def ci?
ENV['TRAVIS']
end
end
2 changes: 0 additions & 2 deletions test/test_sasl.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ def self.xit(msg, &block)
end

it 'gracefully handle authentication failures' do
skip if ci?
memcached(19124, '-S') do |dc|
assert_error Dalli::DalliError, /32/ do
dc.set('abc', 123)
Expand All @@ -41,7 +40,6 @@ def self.xit(msg, &block)
end

it 'fail SASL authentication with wrong options' do
skip if ci?
memcached(19124, '-S') do |dc|
dc = Dalli::Client.new('localhost:19124', :username => 'foo', :password => 'wrongpwd')
assert_error Dalli::DalliError, /32/ do
Expand Down

0 comments on commit f5d9963

Please sign in to comment.