Skip to content
This repository has been archived by the owner on Jun 2, 2020. It is now read-only.

Ignore SIGINT in the Rust worker. #155

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Ignore SIGINT in the Rust worker. #155

merged 1 commit into from
Feb 15, 2019

Conversation

peterhuene
Copy link
Owner

@peterhuene peterhuene commented Feb 15, 2019

This commit ignores SIGINT on both POSIX and Windows, preventing the worker
process from terminating before the Azure Functions Host can gracefully
shutdown the worker process.

However, the Azure Function Host doesn't yet gracefully terminate the worker
process. Without this fix, though, the worker won't properly shut down once
the host does gracefully terminate the worker.

See Azure/azure-functions-host#3296 for that issue.

Fixes #153.

@peterhuene peterhuene added this to the 0.4.1 milestone Feb 15, 2019
@cla-bot cla-bot bot added the cla-signed The CLA has been signed by the contributor. label Feb 15, 2019
This commit ignores SIGINT on both POSIX and Windows, preventing the worker
process from terminating before the Azure Functions Host can gracefully
shutdown the worker process.

However, the Azure Function Host doesn't yet gracefully terminate the worker
process.  Without this fix, though, the worker won't properly shut down once
the host does gracefully terminate the worker.

See Azure/azure-functions-host#3296 for that issue.

Fixes #153.
@peterhuene
Copy link
Owner Author

@rylev as you're on vacation and this is such a small change, I'm going to merge this and release 0.4.1 with the recent fixes.

Also, I've investigated what it would take for a cargo func deploy command to use a combination of the Azure CLI and Azure Function Core Tools to create the functions app (if necessary) and configure it for use with a deployed image. Let's discuss next week.

@peterhuene peterhuene merged commit cf60046 into master Feb 15, 2019
@peterhuene peterhuene deleted the fix-ctrlc branch February 15, 2019 22:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed The CLA has been signed by the contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worker process does not shutdown correctly
1 participant