python 3 support: fix errors related to byte/string conversion #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a lot of errors like "a bytes-like object is required,
not 'str'" and the opposite error.
https://stackoverflow.com/questions/33054527/python-3-5-typeerror-a-bytes-like-object-is-required-not-str-when-writing-t
points out that if you open a file in binary mode, you need to write
bytes, not text. It turns out that Popen with universal_newlines
will open the pipe in text mode rather than binary mode; whereas the
regular file opening calls here are already in text mode, so converting
to utf-8 is not required when writing strings (I hope that means
Python already does that by default).