Skip to content

Commit

Permalink
roachtest: fix version/* tests
Browse files Browse the repository at this point in the history
Use a `quit` command line that is compatible with 2.0. This was
accidentally broken in cockroachdb#28373.

Fixes cockroachdb#28453
Fixes cockroachdb#28454

Release note: None
  • Loading branch information
petermattis committed Aug 10, 2018
1 parent 0757925 commit 6b79e07
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkg/cmd/roachtest/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,10 @@ func registerVersion(r *registry) {
stop := func(node int) error {
l.printf("stopping node %d\n", node)
port := fmt.Sprintf("{pgport:%d}", node)
if err := c.RunE(ctx, c.Node(node), "./cockroach quit --insecure --host=:"+port); err != nil {
// Note that the following command line needs to run against both v2.0
// and the current branch. Do not change it in a manner that is
// incompatible with 2.0.
if err := c.RunE(ctx, c.Node(node), "./cockroach quit --insecure --port="+port); err != nil {
return err
}
// NB: we still call Stop to make sure the process is dead when we try
Expand Down

0 comments on commit 6b79e07

Please sign in to comment.