Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

445 Main and AtRule to use new PostCSS Syntax #446

Merged
merged 20 commits into from May 26, 2022

Conversation

peterramsing
Copy link
Owner

@peterramsing peterramsing commented Nov 8, 2020

What kind of change is this? (Bug Fix, Feature...)

What is the current behavior (You can also link to an issue)

What is the new behavior this introduces (if any)

Does this introduce any breaking changes?

Does the PR fulfill these requirements?

  • Tests for the changes have been added
  • Docs have been added or updated

Other Comments

@codecov
Copy link

codecov bot commented Nov 8, 2020

Codecov Report

Merging #446 (979eacf) into master (2f09e0a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #446   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          775       776    +1     
=========================================
+ Hits           775       776    +1     
Impacted Files Coverage Δ
lib/lost-at-rule.js 100.00% <100.00%> (ø)
lost.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f09e0a...979eacf. Read the comment docs.

@peterramsing peterramsing changed the title 445 upgrade postcss 8 445 Main file to use new PostCSS Syntax Nov 8, 2020
@peterramsing peterramsing changed the title 445 Main file to use new PostCSS Syntax 445 Main and AtRule to use new PostCSS Syntax Nov 11, 2020
lib/lost-at-rule.js Outdated Show resolved Hide resolved
@ThornWalli
Copy link
Contributor

@peterramsing What is the current status here? The priority of postcss update becomes more and more importance...

Get this message when using this plugin, update of postcss-preset-env results in incompatibility.

image

@ThornWalli ThornWalli mentioned this pull request Mar 22, 2022
@peterramsing peterramsing marked this pull request as ready for review May 2, 2022 18:20
@peterramsing
Copy link
Owner Author

Look into getting this releases asap.

@peterramsing peterramsing self-assigned this May 4, 2022
@peterramsing
Copy link
Owner Author

All tests are passing and other issues seem to be resolved with this PR. I'm not ready to release a non-beta version of v8 but this PR seems buttoned up.

@peterramsing peterramsing merged commit 18bb1e7 into master May 26, 2022
@peterramsing peterramsing deleted the 445-upgrade-postcss-8 branch May 26, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants