Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AVX #121

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Add support for AVX #121

merged 6 commits into from
Mar 21, 2024

Conversation

james7132
Copy link
Collaborator

@james7132 james7132 commented Mar 21, 2024

This PR lowers the requirement for 256-bit wide vectors on x86/x86_64 platforms from AVX2 to AVX. #86 mistakenly assumes all of the operations are not available until AVX2, while in reality operations working on __m256d were viable from the start. The main difference is that the code doesn't really use the floating point operations on the type, so the two can be treated the same.

Performance-wise, benchmarks were run and there were zero shown deviations in performance between AVX and AVX2 other than some other incidental speedups in non-set/batch operations.

Used the opportunity to clean up the block directory and deduplicate repeated code and clean up some of the cfg attributes. Also added the new compilation configurations to CI.

@james7132 james7132 merged commit 2937449 into petgraph:master Mar 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant