Fix for scope-related issue with node-webkit#467
Closed
matiaszanolli wants to merge 1 commit intopetkaantonov:masterfrom
Closed
Fix for scope-related issue with node-webkit#467matiaszanolli wants to merge 1 commit intopetkaantonov:masterfrom
matiaszanolli wants to merge 1 commit intopetkaantonov:masterfrom
Conversation
Owner
|
Merged manually, thank you. It will be in the 2.9.3 release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a call to the function setImmediate() on schedule.js that breaks compatibility with the Node-Webkit runtime.
It seems that Node-Webkit combines part of node's global scope with the one used by Chromium. Because of this, some functions have to be called as attributes of the global variable.
I made the replacement, this should not break compatibility with Node but it would be good to give it a try just in case.