Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for scope-related issue with node-webkit #467

Closed
wants to merge 1 commit into from

Conversation

@matiaszanolli
Copy link
Contributor

matiaszanolli commented Jan 26, 2015

There's a call to the function setImmediate() on schedule.js that breaks compatibility with the Node-Webkit runtime.

It seems that Node-Webkit combines part of node's global scope with the one used by Chromium. Because of this, some functions have to be called as attributes of the global variable.

I made the replacement, this should not break compatibility with Node but it would be good to give it a try just in case.

@petkaantonov
Copy link
Owner

petkaantonov commented Jan 27, 2015

Merged manually, thank you. It will be in the 2.9.3 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.