Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix boolean type detection in toavro #504

Merged
merged 1 commit into from
Jul 16, 2020
Merged

fix boolean type detection in toavro #504

merged 1 commit into from
Jul 16, 2020

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Jul 16, 2020 •
edited
Loading

This PR fixes a bug while writing avro files.

Changes

  1. Fixed bool columns detected as int
  2. Added bool columns for testing in CI

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • (Optional) Just a proof of concept
    • (Optional) Work in progress
    • Ready to review
    • Ready to merge

@juarezr juarezr added Bug It must work in all situations, but this failed 3 - Done labels Jul 16, 2020
@juarezr juarezr requested review from alimanfoo and a team July 16, 2020 16:38
@juarezr juarezr self-assigned this Jul 16, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 91.912% when pulling 35874ae on juarezr:fix_avro_bool into 635d5ea on petl-developers:master.

juarezr
juarezr commented Jul 16, 2020
View reviewed changes
Copy link
Member Author

@juarezr juarezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's throwing errors with boolean columns.

@juarezr juarezr merged commit 87f5b0f into petl-developers:master Jul 16, 2020
@juarezr juarezr deleted the fix_avro_bool branch September 17, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimanfoo alimanfoo Awaiting requested review from alimanfoo

Assignees

@juarezr juarezr

Labels
Bug It must work in all situations, but this failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juarezr @coveralls