Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration options for failonerror behaviour #460

Merged
merged 11 commits into from
Aug 6, 2019
Merged

Add configuration options for failonerror behaviour #460

merged 11 commits into from
Aug 6, 2019

Conversation

bmaggard
Copy link
Contributor

@bmaggard bmaggard commented Sep 20, 2018 •
edited by alimanfoo
Loading

This PR resolves #365 by adding a configuration option for failonerror behaviour, allowing errors to be raised rather than silently swallowed during conversion and row mapping functions.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.3%) to 84.766% when pulling c67b5f2 on bmaggard:pr406 into 9372b2a on petl-developers:master.

@bmaggard bmaggard mentioned this pull request Sep 21, 2018
Closed
@alimanfoo alimanfoo changed the title rebased pull request #406 Add configuration options for failonerror behaviour Aug 6, 2019
@alimanfoo alimanfoo merged commit 966e620 into petl-developers:master Aug 6, 2019
@jason-curtis jason-curtis mentioned this pull request Aug 6, 2019
Open
@bmaggard bmaggard deleted the pr406 branch February 3, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimanfoo alimanfoo alimanfoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

convert() and fieldmap() swallow errors silently by default
3 participants
@bmaggard @coveralls @alimanfoo