Fixed helpers.py for Python 3.7 (PEP 479) #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ouch. 2 tiny lines drops the coverage to 89.987. Any quick suggestions? |
alimanfoo
reviewed
Nov 19, 2018
.travis.yml
Outdated
| @@ -3,6 +3,7 @@ branches: | |||
| - master | |||
| language: python | |||
| python: | |||
| - "3.7-dev" | |||
There was a problem hiding this comment.
Which version of Python do you get with this? FWIW I think it should be possible to use latest release 3.7, I did recently for another project, see this .travis.yml.
petl/test/helpers.py
Outdated
| a = cast(a) | ||
| eq_(e, a) | ||
| except: | ||
| return |
There was a problem hiding this comment.
If this is needed because there is code inside petl that raises StopIteration from inside a generator, then I think it would be better to fix the code rather the test. To deal with PEP 479 change I believe we can just replace "raise StopIteration" with a bare "return" instead.
Closed
|
Thanks again @dhait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification to fix nosetest helpers.py failing due to changes in Python 3.7 (PEP 479)
nosetests -v and tox -e py27,py36,py37 all passed after modifications.
No new unit tests
No new functions