Changed _Keyed class in sorts, so that comparisons are only by keys #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DiegoEPaez
commented
Apr 2, 2019
DiegoEPaez
commented
- Includes unit tests
- New functions have docstrings with examples that can be run with doctest
- New functions are included in API docs
- Docstrings include notes for any changes to API or behaviour
- Travis CI passes (unit tests run under Linux)
- AppVeyor CI passes (unit tests run under Windows)
- Unit test coverage has not decreased (see Coveralls)
- All changes documented in docs/changes.rst
1 similar comment
|
Going ahead with merge but happy to revisit if any comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.