Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed _Keyed class in sorts, so that comparisons are only by keys #466

Merged
merged 3 commits into from Aug 6, 2019

Conversation

@DiegoEPaez
Copy link
Contributor

commented Apr 2, 2019

  • Includes unit tests
  • New functions have docstrings with examples that can be run with doctest
  • New functions are included in API docs
  • Docstrings include notes for any changes to API or behaviour
  • Travis CI passes (unit tests run under Linux)
  • AppVeyor CI passes (unit tests run under Windows)
  • Unit test coverage has not decreased (see Coveralls)
  • All changes documented in docs/changes.rst
@coveralls

This comment has been minimized.

Copy link

commented Apr 2, 2019

Coverage Status

Coverage decreased (-1.2%) to 89.928% when pulling 0961b19 on DiegoEPaez:heap-cmp-bug into 1d33ca0 on petl-developers:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Apr 2, 2019

Coverage Status

Coverage decreased (-1.2%) to 89.928% when pulling 0961b19 on DiegoEPaez:heap-cmp-bug into 1d33ca0 on petl-developers:master.

alimanfoo added 2 commits Aug 6, 2019
@alimanfoo

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

Going ahead with merge but happy to revisit if any comments.

@alimanfoo alimanfoo merged commit b226acf into petl-developers:master Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.