-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add helpers for xz, lz4 and zstandard codec and for s3 and smb remote servers #491
Conversation
Hi @juarezr, this all looks like a great improvement to me, no specific comments. One thing to note, there is a new project called fsspec which provides common access to a variety of different file-system-like sources, with dispatching based on a URL-like string syntax. E.g., calling |
Hi, @alimanfoo ,
Thanks |
Very happy with that approach. |
I looked at
Maybe you can share your opinions about these point. 😄 Next time that I'll have time available, I will explore further. But for now, do you think we can proceed with the |
I think so, let's merge this PR, then you can investigate fsspec further if and when you think useful. Is this PR ready to merge? |
Right, support for 'smb://' would need to be special cased within petl, or contributed upstream to fsspec.
I believe fsspec could handle local filesystems.
I don't know, sorry.
I imagine some of the existing sources could be removed and use fsspec instead. |
Yes. This PR is ready to merge. |
I will check this later, when I could get time available.
This makes easier for going further. Do youn know if some breakage will happen if the existing sources are removed? |
v1.5.0 released to pypi and conda-forge |
Yes, I imagine some people may have code that would break. Ideally we would deprecated those features (raise a DeprecationWarning) but leave them there for the next version, and then we could remove them in the version after that. |
Looks like a good way to go further. Thanks for the release. |
add helpers for xz, lz4 and zstandard codec and for s3 and smb remote servers
Changes
to...()
andfrom...()
functions for allowing dynamic adding sources.petl.io.sources.register_reader
andpetl.io.sources.register_writer
for registering custom source helpers for handling I/O from remote protocols.petl.io.sources.register_codec
for registering custom helpers for compressing and decompressing files with other algorithms.petl.io.codec.xz.XZCodec
,petl.io.codec.xz.LZ4Codec
andpetl.io.codec.zstd.ZstandardCodec
for compressing files withXZ
and the "state of art"LZ4
andZstandard
algorithms.petl.io.source.s3.S3Source
andpetl.io.source.smb.SMBSource
reading and writing files to remote servers using int url the protocolss3://
andsmb://
.Ready for comments.
Checklist