Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsspec: fixing build and dependencies #508

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Aug 4, 2020

This PR has the objective of fixing the build that is not working.

The problem is registered in this issue

Changes

  1. Added package aiohttp to optional_requirements.txt
  2. Added a http optional dependecy in extra_requires in setup.py

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • Ready to review
    • Ready to merge

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.912% when pulling 4e2ddcd on juarezr:fix_aiohttp into 9ae3fc4 on petl-developers:master.

@juarezr
Copy link
Member Author

juarezr commented Aug 4, 2020

Proceeding with the merge because:

@juarezr juarezr merged commit 051320c into petl-developers:master Aug 4, 2020
@juarezr juarezr deleted the fix_aiohttp branch August 4, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants