Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #514: fromxlsx with read_only crashes #515

Merged
merged 3 commits into from
Sep 11, 2020

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Sep 11, 2020

This PR fixes a problem reported on #514

Changes

  1. Added test for fromxlsx(read_only=True)
  2. Fixed a bug in fromxlsx with read_only=True

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • Ready to review
    • Ready to merge

@juarezr juarezr linked an issue Sep 11, 2020 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Sep 11, 2020

Coverage Status

Coverage decreased (-0.9%) to 91.071% when pulling c4aa8a4 on juarezr:fix_xlsx_readonly into feeb3be on petl-developers:master.

@juarezr juarezr merged commit a66a640 into petl-developers:master Sep 11, 2020
@juarezr juarezr deleted the fix_xlsx_readonly branch September 12, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fromxlsx with read_only crashes: ValueError: seek of closed file
2 participants