Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added py38 and py39 to tox.ini for newer distros #517

Merged
merged 5 commits into from
Sep 23, 2020
Merged

Added py38 and py39 to tox.ini for newer distros #517

merged 5 commits into from
Sep 23, 2020

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Sep 17, 2020 •
edited
Loading

This PR has the objective of building petl with python3.8 and python3.9

Changes

  1. Added new environments py38 and py39 to tox.ini.
  2. Build with py38 in linux on travis-ci
  3. Build with py38 in windows on appveyor

Limitations

  • Package pandas doens't build with py39 yet.
  • Packages numpy==1.19.2 and Cython==0.29.21 fails to build with py39.
  • Can py39 fix with:
    • Cython<0.29.21,>=0.29.13
    • numpy<=1.19.2,>=1.16.4
    • numexpr<=2.7.1,>=2.6.9
    • pandas<=1.1.2,>=0.24.2 ; python_version < '3.9'

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • (Optional) Work in progress
    • Ready to review
    • Ready to merge

@juarezr
Added py38 and py39 to tox.ini for newer distros
fc3524c 
Package pandas that doens't build with py39 yet.
Packages numpy==1.19.2 and Cython==0.29.21 fails to build with py39.
Can fix with:
  Cython<0.29.21,>=0.29.13
  numpy<=1.19.2,>=1.16.4
  numexpr<=2.7.1,>=2.6.9
  pandas<=1.1.2,>=0.24.2 ; python_version < '3.9'
@coveralls
Copy link

coveralls commented Sep 17, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 91.957% when pulling 0a8a696 on juarezr:py38 into 0a74c0e on petl-developers:master.

@juarezr juarezr added the Maintainability Issues for code modernization, improve development, testing label Sep 17, 2020
@juarezr juarezr merged commit 704cbe4 into petl-developers:master Sep 23, 2020
@juarezr juarezr deleted the py38 branch September 23, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimanfoo alimanfoo Awaiting requested review from alimanfoo

Assignees
No one assigned
Labels
Maintainability Issues for code modernization, improve development, testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juarezr @coveralls