Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Lines Support #519

Closed
wants to merge 1 commit into from
Closed

JSON Lines Support #519

wants to merge 1 commit into from

Conversation

fahadsiddiqui
Copy link
Contributor

@fahadsiddiqui fahadsiddiqui commented Sep 21, 2020 •
edited
Loading

This PR has the objective of...

Changes

  1. Added JSON lines support https://jsonlines.org/examples/

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • (Optional) Just a proof of concept
    • (Optional) Work in progress
    • Ready to review
    • Ready to merge

@coveralls
Copy link

coveralls commented Sep 21, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-2.2%) to 89.791% when pulling a9a1a90 on fahadsiddiqui:master into 0a74c0e on petl-developers:master.

@fahadsiddiqui fahadsiddiqui reopened this Sep 21, 2020
@juarezr juarezr added Feature A nice to have thing that we don't have yet Usability Improvement that benefit petl usage for end users labels Sep 22, 2020
@juarezr
Copy link
Member

juarezr commented Sep 22, 2020

Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimanfoo alimanfoo Awaiting requested review from alimanfoo

Assignees
No one assigned
Labels
Feature A nice to have thing that we don't have yet Usability Improvement that benefit petl usage for end users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fahadsiddiqui @coveralls @juarezr