Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added toxml() as convenience wrapper over totext() #529

Merged
merged 5 commits into from
Dec 24, 2020
Merged

Added toxml() as convenience wrapper over totext() #529

merged 5 commits into from
Dec 24, 2020

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Oct 7, 2020 •
edited
Loading

This PR has the objective of adding a new function toxml()

Changes

  1. Added new new function toxml()
  2. Added doc strings for toxml()

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • Ready to review
    • Ready to merge

@juarezr juarezr added Feature A nice to have thing that we don't have yet Usability Improvement that benefit petl usage for end users labels Oct 7, 2020
@juarezr juarezr requested a review from alimanfoo October 7, 2020 00:03
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 89.744% when pulling 61b7600 on juarezr:toxml into b8068f8 on petl-developers:master.

@coveralls
Copy link

coveralls commented Oct 7, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 91.952% when pulling 03795e8 on juarezr:toxml into b8068f8 on petl-developers:master.

@juarezr juarezr changed the title Added toxml() as wrapper to totext() Added toxml() as convenience wrapper over totext() Oct 7, 2020
@juarezr juarezr force-pushed the toxml branch 3 times, most recently from 364dcbe to ac9db79 Compare October 7, 2020 21:32
@juarezr juarezr merged commit b22880e into petl-developers:master Dec 24, 2020
@juarezr juarezr deleted the toxml branch December 24, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimanfoo alimanfoo Awaiting requested review from alimanfoo

Assignees
No one assigned
Labels
Feature A nice to have thing that we don't have yet Usability Improvement that benefit petl usage for end users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juarezr @coveralls