Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ci for testing petl on github actions on all push and pull_request #543

Merged
merged 3 commits into from
Mar 18, 2021

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Feb 23, 2021

This PR added ci for testing petl on github actions on all push and pull_request.

Changes

This performs the same tests already executing on travis and appveyor:

  • run nosetests testing for cases under test folder
  • run nosetest with doctest for embedded tests
  • run coverage tests with coveralls
  • run sphinx docs testing
  • run test on python versions 2.7 3.6 3.7 3.8 3.9
  • run on linux and windows

Also some improvements:

  • install dockers with postgresql and mysql for fromdb() todb() testing
  • install docker with sftp and samba for testing remote files read/write
  • run also on mac-os beyond ubuntu and windows
  • increased the test span on python 2.7 and 3.9
  • travis and appveyor still works

Caveats:

  • bcolz fails to build on CI and is skipped
  • doctest fails on some targes (works fully on python > 3.6 and ubuntu)
  • docker containers only available for ubuntu
  • no testing on arm architeture/targets
  • some warnings on xml test cases with recent lxml package
  • no support for release on pip/conda (currently on travis-ci)

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • (Optional) Just a proof of concept
    • (Optional) Work in progress
    • Ready to review
    • Ready to merge

This performs the same tests already executing on travis and appveyor:

- run nosetests testing for cases under test folder
- run nosetest with doctest for embedded tests
- run coverage tests with coveralls
- run sphinx docs testing
- run test on python versions 2.7 3.6 3.7 3.8 3.9
- run on linux and windows

Also some improvements:

- install dockers with postgresql and mysql for fromdb() todb() testing
- install docker with sftp and samba for testing remote files read/write
- run also on mac-os beyond ubuntu and windows
- increased the test span on python 2.7 and 3.9
- travis and appveyor still works

Caveats:

- bcolz fails to build on CI and is skipped
- doctest fails on some targes (works fully on python > 3.6 and ubuntu)
- docker containers only available for ubuntu
- no testing on arm architeture/targets
- some warnings on xml test cases with recent lxml package
- no support for release on pip/conda (currently on travis-ci)
@coveralls
Copy link

coveralls commented Feb 23, 2021

Coverage Status

Coverage decreased (-0.6%) to 91.264% when pulling 53740c0 on juarezr:github_actions_ci into 02480fa on petl-developers:master.

@juarezr juarezr added 2 - Working Maintainability Issues for code modernization, improve development, testing labels Mar 18, 2021
@juarezr juarezr merged commit e9b3e87 into petl-developers:master Mar 18, 2021
@juarezr juarezr deleted the github_actions_ci branch March 18, 2021 00:18
@juarezr juarezr added Build CI CD Issues affecting github pypi readthedocs coveralls conda-forge and removed 2 - Working labels Feb 2, 2022
@juarezr juarezr added this to the v2.0 milestone Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build CI CD Issues affecting github pypi readthedocs coveralls conda-forge Maintainability Issues for code modernization, improve development, testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants