Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to use convert with custom function #544

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Document how to use convert with custom function #544

merged 1 commit into from
Mar 23, 2021

Conversation

javidy
Copy link
Contributor

@javidy javidy commented Mar 22, 2021 •
edited
Loading

Fixes #542

This PR has the objective of...giving an example of using a custom function with petl.transform.conversions.convert()

Changes

  1. Improved the docs about...petl.transform.conversions.convert() providing example usage of custom function

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • (Optional) Just a proof of concept
    • (Optional) Work in progress
    • Ready to review
    • Ready to merge

@javidy javidy changed the title Update conversions.py Document how to use convert with custom function Mar 22, 2021
@coveralls
Copy link

coveralls commented Mar 22, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 90.007% when pulling 66f0716 on javidy:patch-1 into e9b3e87 on petl-developers:master.

@javidy javidy marked this pull request as ready for review March 23, 2021 19:06
@javidy
Copy link
Contributor Author

javidy commented Mar 23, 2021

hi @juarezr ,
would you be kind to review my PR :)

juarezr
juarezr approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@juarezr juarezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.

@juarezr juarezr merged commit ff6e7a3 into petl-developers:master Mar 23, 2021
@javidy javidy deleted the patch-1 branch March 23, 2021 19:38
@javidy
Copy link
Contributor Author

javidy commented Mar 23, 2021

thanks a lot @juarezr , it was my first PR and I'm happy that it was merged :)
hope I'll have many more valuable contributions in future.

@juarezr
Copy link
Member

juarezr commented Mar 23, 2021

Welcome @javidy and @carlcorder !!!

🥇

@juarezr
Copy link
Member

juarezr commented Mar 23, 2021

It looks like docs building / deploying CI is broken now...

@javidy
Copy link
Contributor Author

javidy commented Mar 24, 2021

@juarezr how can I help to fix the issue? Would be happy to do that.

@javidy
Copy link
Contributor Author

javidy commented Mar 24, 2021

I'm running doctests using tox as mentioned in documentation. Maybe it'll give me a clue.

@juarezr
Copy link
Member

juarezr commented Mar 24, 2021

Local doctests and CI are working fine.

The problem could be someplace involving:

  • Github
  • Travis CI
  • readthedocs.io

@juarezr juarezr mentioned this pull request Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juarezr juarezr juarezr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to use convert with custom function and reference row
3 participants
@javidy @coveralls @juarezr