Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support '--extensions' on Windows #63

Merged
merged 1 commit into from
Jun 22, 2012
Merged

Support '--extensions' on Windows #63

merged 1 commit into from
Jun 22, 2012

Conversation

heycalmdown
Copy link
Contributor

The option "--extensions" is useful when touching .jade-like file types which doesn't need to restart to apply it. But it didn't work on Windows.

@iangreenleaf
Copy link
Collaborator

Cool, thanks! This looks good, so I'm going to merge it now, but I want to test it a little bit before I publish a new version on npm, and it might be a few days before I have time to do that.

iangreenleaf added a commit that referenced this pull request Jun 22, 2012
Support '--extensions' on Windows
@iangreenleaf iangreenleaf merged commit 860a647 into petruisfan:master Jun 22, 2012
@iangreenleaf
Copy link
Collaborator

Looking at this a second time, I'm less certain. I ran into problems, detailed in #34, when trying to use watch on too many files. If that's a problem on Windows too, I don't want to saddle people with outright breakage to get this feature in.

@iangreenleaf
Copy link
Collaborator

There's a syntax error too, so I'm gonna roll this back for the moment since I want to get a 0.8 release out.

@iangreenleaf
Copy link
Collaborator

I'm now looking at #60 and the author is implementing ignores by using the filename passed to the callback (while still calling watch just once on the whole directory). I'll probably merge that PR soon, so it seems like you could plug on top of his code for a more stable solution.

Also, I'd love it if you could test that ignore feature and let me know if it works on Windows.

@heycalmdown
Copy link
Contributor Author

Ok, let me know which version would contain the patch #60

@iangreenleaf
Copy link
Collaborator

0.4.1 is out now and includes that patch.
On Jun 26, 2012 5:37 PM, "Kei Son" <
reply@reply.github.com>
wrote:

Ok, let me know which version would contain the patch #60


Reply to this email directly or view it on GitHub:
#63 (comment)

@heycalmdown
Copy link
Contributor Author

0.4.1 doesn't work of watching modifications at all.
I'll dig it later.

@phairow
Copy link

phairow commented Aug 28, 2012

does watch work on windows yet with specified extensions? I don't see it working for me.

@iangreenleaf
Copy link
Collaborator

Nope, sorry. @heycalmdown improved Windows file watching in #70, so this feature could be revisited, perhaps with greater success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants