forked from linux-test-project/ltp
-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
syscalls/quotactl: Don't use ltp-quota.m4
Current quotactl01.c has logic problem. There is no relation between Q_GETINFO and quota format. The format should depend on quotacheck -F and kernel config such as CONFIG_QFMT_V1 or CONFIG_QFMT_V2 (most linux distributions use the v2). Q_GETINFO cmd was introduced since Linux 2.4.22, we don't need to check it now. Also, specify quota format to QFMT_VFS_V0 by quotacheck -F and check CONFIG_QFMT_V2 in kernel config to avoid issue such as linux-test-project#189 [1]. So in quotactl01.c, we don't need to use the macro of ltp-quota.m4. In quotactl0[2-3].c, we don't need to check very basic header <sys/quota.h> (it was introdued in glibc since 1997). Remove quota version macro. Don't remove ltp-quota.m4 because I will rewrite it to detect if_nextdqblk struct for Q_GETNEXTQUOTA cmd on the coming patch. [1]linux-test-project#189 Reviewed-by: Petr Vorel <pvorel@suse.cz> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> Signed-off-by: Petr Vorel <pvorel@suse.cz>
- Loading branch information
1 parent
58f21cc
commit bad28b6
Showing
3 changed files
with
22 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters