Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pex --venv mode does not account for PEX_PATH. #1225

Closed
jsirois opened this issue Feb 6, 2021 · 0 comments · Fixed by #1227
Closed

Pex --venv mode does not account for PEX_PATH. #1225

jsirois opened this issue Feb 6, 2021 · 0 comments · Fixed by #1227
Assignees
@jsirois
Labels
bug

Comments

@jsirois
Copy link
Member

jsirois commented Feb 6, 2021 •
edited
Loading

When PEX_PATH is specified at runtime, it should trigger a venv re-build as needed.
Currently we only rebuild for interpreter contraints changes, PEX_PYTHON and PEX_PYTHON_PATH changes; i.e.: changes that could affect the correct interpreter to build the venv with:
https://github.com/pantsbuild/pex/blob/dd5c86f38ef76090089f88da8a4cefd8769a47c9/pex/variables.py#L648-L668
@jsirois jsirois added the bug label Feb 6, 2021
@jsirois jsirois self-assigned this Feb 6, 2021
@jsirois jsirois mentioned this issue Feb 6, 2021
Closed
1 task
jsirois added a commit to jsirois/pex that referenced this issue Feb 7, 2021
@jsirois
Fix --venv mode to respect PEX_PATH.
b7cb6fa 
Virtual environments are now rebuilt when PEX_PATH is mutated.

Fixes pex-tool#1225
@jsirois jsirois mentioned this issue Feb 7, 2021
Merged
jsirois added a commit that referenced this issue Feb 7, 2021
@jsirois
Fix --venv mode to respect PEX_PATH. (#1227)
7147601 
Virtual environments are now rebuilt when PEX_PATH is mutated.

Fixes #1225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix --venv mode to respect PEX_PATH. jsirois/pex
1 participant
@jsirois